Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linearlite): Fix linearlite deps #1415

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

msfstef
Copy link
Contributor

@msfstef msfstef commented Jul 1, 2024

I've updated the linearlite dependency as it was failing to build and also modified the toolbar workspace dependencies to allow for the closest patch version rather than the exact one.

We might want to do something similar for the CLI and Drivers packages but since they are more tightly coupled we can keep them as workspace:* rather than workspace:~ - once we move to v1 we might want worksapce:^

@msfstef msfstef requested a review from kevin-dp July 1, 2024 15:17
Copy link
Contributor

@kevin-dp kevin-dp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
"electric-sql": "workspace:~" dependency may be slightly dangerous as we are in alpha and may introduce a breaking change on the client with only a patch bump. Need to remember to specify the dependency more specifically when that happens.

@msfstef msfstef merged commit 5ced128 into main Jul 2, 2024
40 checks passed
@msfstef msfstef deleted the msfstef/fix-linearlite-deps branch July 2, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants