-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(electric): Enable introspection of electrified enum types in the proxy #670
Conversation
e7faa6d
to
495ff8b
Compare
cd13b02
to
6ee853f
Compare
1e735cf
to
ae7d07d
Compare
6ee853f
to
e1d7021
Compare
ff79b4f
to
89f59d4
Compare
This PR adds support for enumerations by: - modifying the generator to store enumeration types as "TEXT" type in the generated client - modifying satellite to serialise/deserialise enumerations as text - since enumeration types are unknown to Satellite it serialises/deserialises them as text
89f59d4
to
d44cb3a
Compare
@alco I'm trying out the PR with the an enum migration but the introspection fails with the following error.
|
@davidmartos96 I haven't tested it after the redesign of internal representation of enums done in #804 Thanks for sharing your log! I'll run some tests tomorrow and will get back to you. |
@davidmartos96 There was a bug in the implementation. Please try again using the latest commit here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
… proxy (#670) Fixes VAX-1042. --------- Co-authored-by: Kevin <[email protected]>
Fixes VAX-1042.