feat (DAL): client-side support for float4 #671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds client-side support for float4.
Numbers provided by the user are rounded to the nearest float4 representation using
Math.fround()
.Similarly, when numbers are read from a float4 column in the DB they are rounded to the nearest float4 representation.
This would not strictly be necessary if all writes happen through the DAL but because of SQLite's dynamic typing, users can write larger/smaller numbers to float4 columns in which case we would read numbers that fall out of range.