feat(electric): Prevent updates to table PKs #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UpdatedRecord now has a changed_columns key...
magnetised
force-pushed
the
garry/vax-1324-prevent-updates-to-table-pks
branch
from
7c17ae3
to
1aee580
Compare
alco
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Nice work!
Does this need a matching client-side validation to prevent well-behaving clients from sending updates to PK columns in the first place? If it does, then we should hold off merging this PR at least until after we publish 0.8.x this week.
Also a friendly reminder to add a changeset.
components/electric/test/electric/postgres/extension/schema_cache_test.exs
Outdated
Show resolved
Hide resolved
components/electric/lib/electric/satellite/write_validation/immutable_primary_key.ex
Outdated
Show resolved
Hide resolved
| assert {:ok, ["id", "owner"]} = | ||
| SchemaLoader.Version.primary_keys(schema, "public", "compound_pk") | ||
|
|
||
| {:ok, schema: schema} |
There was a problem hiding this comment.
FYI there's no need to return a tagged tuple from setup callbacks. This could simply be %{schema: schema}.
magnetised
force-pushed
the
garry/vax-1324-prevent-updates-to-table-pks
branch
from
7b7059b
to
58f9077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.