Closed
Conversation
github-actions
bot
added
the
exchange config
VIKTORVAV99
reviewed
Dec 10, 2024
Member
There was a problem hiding this comment.
This file should be named GB_GB-ZET.yaml if the intention is to create and exchange between mainland GB and the Shetland Islands.
Member
|
Thanks for the contribution but it needs some adjusting before we can merge it. |
Member
|
Closing this as there as been no activity in months. We'll evaluate how to handle GB-ZET internally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #7269 - Creates GB_ZET config in order to expand to allow for exchanges.
Description
Ensure the config for the exchange / future exchanges between GB and ZET is in place.
Preview
Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.