Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IM.yaml #7591

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update IM.yaml #7591

wants to merge 4 commits into from

Conversation

CHirch
Copy link

@CHirch CHirch commented Dec 20, 2024

Added capacity information Isle of Man and added interconnector FR - JE

Description

Added capacity information from manxutilities homepage and Interconnector https://www.jec.co.uk/about-us/our-businesses/energy-division/

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

Added capacity information
@github-actions github-actions bot added the zone config Pull request or issue for zone configurations label Dec 20, 2024
@github-actions github-actions bot added the exchange config Pull request or issue for exchange configurations label Dec 20, 2024
@VIKTORVAV99 VIKTORVAV99 self-requested a review December 20, 2024 12:01
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good but there is one tiny thing to look at!

Thanks for the PR!

@@ -10,5 +28,12 @@ fallbackZoneMixes:
gas: 0.988
hydro: 0.007
oil: 0.005
- _source: https://www.manxutilities.im/media/3096/manx-utilities-annual-report-and-accounts-31-march-2024.pdf
datetime: '2024-12-20'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This datetime means it will only be used from this date and forward, I assume this is not what you want?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not sure about the fuction of the datetime attribute as I was not able to find it in the documentation. I tried to reverse engineer from other config files an thought it was the date of the last edit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's from the first date the data is valid.

So if it is for example 2023-01-01 it will be used from 2023-01-01 and forward.

If there is one for 2023-01-01 and 2024-01-01 then the 2023-01-01 value will be used between 2023-01-01 and 2024-01-01 and then 2024-01-01 will be used for all values after 2024-01-01.

@VIKTORVAV99 VIKTORVAV99 marked this pull request as draft December 21, 2024 16:41
date corrected
@CHirch CHirch marked this pull request as ready for review December 21, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exchange config Pull request or issue for exchange configurations zone config Pull request or issue for zone configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants