feat(web): link data portal from app #7703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIKTORVAV99
requested changes
Jan 8, 2025
Comment on lines
+8
to
+17
| function getCountryToDownload(zoneId?: string) { | ||
| if (!zoneId) { | ||
| return ''; | ||
| } | ||
|
|
||
| const zoneName = getZoneName(zoneId); | ||
| const zoneCountryName = | ||
| zoneId && zoneId.includes('-') && getCountryName(zoneId)?.toLowerCase(); | ||
| return zoneCountryName || zoneName; | ||
| } |
There was a problem hiding this comment.
This don't really work as it gets the translated name of the country. So it breaks for everything except English.
Comment on lines
+26
to
+32
| <Button | ||
| href={url} | ||
| icon={<Download size={DEFAULT_ICON_SIZE} />} | ||
| type="tertiary" | ||
| size="md" | ||
| aria-label="Download CSV Data" | ||
| /> |
There was a problem hiding this comment.
Can we mark that this is an external link just like we do in the header the desktop view?
| ); | ||
| } | ||
|
|
||
| export default DownloadCsv; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We don't have enough visibility of the data portal in the app
Description
This PR adds download button to the zone header which links to the appropriate page of the data portal
Preview
TODO
Only show button when zone has data in the data portal
Finalize design and button placement