Skip to content

Conversation

xudafeng
Copy link
Member

Summary

  • upgrade electron to v34 and align related packages
  • update Node types and tooling for Electron 34 compatibility

Testing

  • npm install (fails: 403 Forbidden - GET https://registry.npmjs.org/@electron%2fasar)
  • npm run lint (fails: ESLint couldn't find eslint.config.js)
  • npm run tsc (fails: cannot find module 'electron' and other declarations)
  • npm test (fails: nyc not found)
  • npm run build (fails: multiple TypeScript errors)
  • npm run dev (fails: gulp not found)

https://chatgpt.com/codex/tasks/task_e_68b47a0641b4832183ceac16f732a7b4

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines 36 to 39
"devDependencies": {
"@applint/spec": "^1.2.3",
"@electron/asar": "3",
"@types/jest": "^26.0.24",
"@types/lodash": "^4.14.181",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Restore @applint/spec for ESLint to load

.eslintrc.js still calls require('@applint/spec'), but this commit removed @applint/spec from devDependencies. After installing dependencies, npm run lint will throw Cannot find module '@applint/spec' because the configuration package is no longer present. Keep the dependency or replace the ESLint config with an alternative so linting can run.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant