Skip to content

feat: support Icon Composer files as icon inputs for macOS #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: support Icon Composer files as icon inputs for macOS #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
/**
* Path to the icon to use for the app in the DMG window.
*/
icon?: string;
icon?: string | string[];
/**
* How big to make the icon for the app in the DMG.
*
Expand Down Expand Up @@ -157,7 +157,15 @@
if (!opts.icon) {
spec.icon = path.resolve(__dirname, '../resources/mac/electron.icns');
} else {
spec.icon = path.resolve(opts.icon);
const iconFilenames = Array.isArray(opts.icon)
? opts.icon
: [opts.icon];
for (let iconFilename of iconFilenames) {

Check failure on line 163 in src/index.ts

View workflow job for this annotation

GitHub Actions / build (18.x) 

'iconFilename' is never reassigned. Use 'const' instead

Check failure on line 163 in src/index.ts

View workflow job for this annotation

GitHub Actions / build (16.x) 

'iconFilename' is never reassigned. Use 'const' instead
const ext = path.extname(iconFilename);
if (ext !== 'icns') {
spec.icon = path.resolve(iconFilename);
}
}
}

spec['icon-size'] = opts.iconSize || 80;
Expand Down
Loading