fix: isUnpackedDir matches non-child directories that have same folder name prefix

[mmaietta]

Fixes: #331 and updates test case for minimatch patterns. (Happy to write additional or separate tests if preferred)

Test project file structure:

/project# tree "/tmp/et-db411cd21f3bbd882f3a5a30c58db6ff/t-jp88Jv/asar-app-1"
/tmp/et-db411cd21f3bbd882f3a5a30c58db6ff/t-jp88Jv/asar-app-1
├── app
│   ├── package.json
│   │   └── readme.md
│   └── readme.md
├── index.html
├── index.js
├── node_modules
│   ├── @electron-builder
│   │   ├── test-smart-unpack
│   │   │   ├── foo.dll
│   │   │   └── package.json
│   │   └── test-smart-unpack-empty
│   │       └── package.json

The pattern passed to unpackDir minimatch glob.

pattern = "{node_modules/@electron-builder/test-smart-unpack,node_modules/edge-cs}"

asar/src/asar.ts

Lines 22 to 31 in 464e834

	function isUnpackedDir(dirPath: string, pattern: string, unpackDirs: string[]) {
	if (dirPath.startsWith(pattern) || minimatch(dirPath, pattern)) {
	if (!unpackDirs.includes(dirPath)) {
	unpackDirs.push(dirPath);
	}
	return true;
	} else {
	return unpackDirs.some((unpackDir) => dirPath.startsWith(unpackDir));
	}
	}

The issue I'm running into is that test-smart-unpack-empty is not supposed to be getting unpacked as it fails the minimatch, but the else logic in isUnpackedDir is causing it to do a startsWith match on the folder path and then returns true.

This PR introduces a check to make sure that the previous folders being unpacked do not include folders that happen to have the same prefix but are not a child directory of a previously flagged unpacked directory.

Additional note, this does not change logic for non-minimatch patterns (e.g. --unpack-dir dir2/subdir) as that logic flow is left unchanged.

asar/src/asar.ts

Line 23 in 464e834

if (dirPath.startsWith(pattern) || minimatch(dirPath, pattern)) {

[continuous-auth]

🎉 This PR is included in version 3.2.17 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀