fix: inline @types/glob
#336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikian
force-pushed
the
fix/inline-glob-types
branch
from
565ba74
to
cb50f1c
Compare
ckerr
approved these changes
Oct 24, 2024
BlackHole1
approved these changes
Oct 25, 2024
|
🎉 This PR is included in version 3.2.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
This doesn't appear to fix anything for me. The new type def file isn't included in the npm package.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically just copy-pasted from #268; as discussed in #332 (comment), we used to inline these types to avoid issues downstream, but that was lost when #320 landed so this is just restoring our previous workaround.