-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Fiddle snap package #1348
Draft
VerteDinde
wants to merge
15
commits into
main
Choose a base branch
from
add-snap-package
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+60
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
force-pushed
the
add-snap-package
branch
from
May 2, 2023 03:04
339c4e0
to
c4cd192
Compare
VerteDinde
force-pushed
the
add-snap-package
branch
2 times, most recently
from
May 2, 2023 03:28
f489038
to
9ec848d
Compare
VerteDinde
force-pushed
the
add-snap-package
branch
from
May 2, 2023 03:29
9ec848d
to
62bc0dd
Compare
VerteDinde
force-pushed
the
add-snap-package
branch
from
May 2, 2023 03:49
beec644
to
9a9a873
Compare
VerteDinde
force-pushed
the
add-snap-package
branch
2 times, most recently
from
May 2, 2023 04:32
1f2dded
to
7cd43bc
Compare
VerteDinde
force-pushed
the
add-snap-package
branch
from
May 2, 2023 05:02
7cd43bc
to
0d1af20
Compare
VerteDinde
force-pushed
the
add-snap-package
branch
from
May 2, 2023 18:40
6d40ec0
to
8ab847e
Compare
VerteDinde
force-pushed
the
add-snap-package
branch
from
May 2, 2023 19:42
71defdf
to
61281ed
Compare
codebytere
approved these changes
May 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good to me! A few comments but they're non-blocking.
dsanders11
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Fiddle snap distributable and tests out our CI setup for snap development.
The current snap binary can be installed by running
sudo snap install --dangerous <binary-name>
. If we want to upload the build to the official Snap store, we'll have to create an account and vet the binary there. Minus Snap store submission, this PR should be ready for review.Improvement list: