-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: lint JavaScript code #1741
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1741 +/- ##
==========================================
+ Coverage 89.06% 89.28% +0.22%
==========================================
Files 17 17
Lines 905 905
Branches 187 187
==========================================
+ Hits 806 808 +2
+ Misses 62 61 -1
+ Partials 37 36 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node.js engine incompatibilities
🎉 This PR is included in version 18.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@typescript/eslint
on*.ts
files.peerDependencies
requirements.There was a difference in how we apply semi-colons, function parameter spaces, and comma dangles between the JS and TS code, and I just kept this as similar as possible to minimize the diff here.