Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint JavaScript code #1741

Merged
merged 3 commits into from
Jun 25, 2024
Merged

chore: lint JavaScript code #1741

merged 3 commits into from
Jun 25, 2024

Conversation

erickzhao
Copy link
Member

  • Lints our JavaScript test code by only using @typescript/eslint on *.ts files.
  • Upgrades some dependencies to add peerDependencies requirements.

There was a difference in how we apply semi-colons, function parameter spaces, and comma dangles between the JS and TS code, and I just kept this as similar as possible to minimize the diff here.

@erickzhao erickzhao requested a review from a team as a code owner June 25, 2024 21:29
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.28%. Comparing base (0353a8a) to head (fb7ed8a).
Report is 15 commits behind head on main.

Files Patch % Lines
src/universal.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1741      +/-   ##
==========================================
+ Coverage   89.06%   89.28%   +0.22%     
==========================================
  Files          17       17              
  Lines         905      905              
  Branches      187      187              
==========================================
+ Hits          806      808       +2     
+ Misses         62       61       -1     
+ Partials       37       36       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node.js engine incompatibilities

@erickzhao
Copy link
Member Author

erickzhao commented Jun 25, 2024

Sorry, I ran uuaw on @typescript-eslint/eslint-plugin to silence a warning but it seems like there was an engines bump in a minor bump that they forgot to add in v7. Downgraded in c05a935 fb7ed8a.

@erickzhao erickzhao requested a review from dsanders11 June 25, 2024 22:05
@erickzhao erickzhao merged commit 92e2cbe into main Jun 25, 2024
4 of 5 checks passed
@erickzhao erickzhao deleted the chore/eslint-js branch June 25, 2024 22:16
Copy link

🎉 This PR is included in version 18.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants