Removed unneeded conditional

[hjerpbakk]

No description provided.

[Grinshpon]

That's not an unneeded conditional. It says if the damage value is zero the function returns zero.

[Berzeger]

Grinshpon, the condition that follows immediately after checks for that again, so I'd say it's unnecessary.

[smbkr]

The original implementation could have been an optimisation, if the checks that follow were expensive to perform, allowing the function to return early before incurring that cost -- however this is probably irrelevant in 2020.

[hjerpbakk]

This is not a performance improvement, but rather a removing of redundant code and brings this check to parity with

CnC_Remastered_Collection/TIBERIANDAWN/COMBAT.CPP

Line 75 in d9e287e

if (Special.IsInert || !damage || warhead == WARHEAD_NONE) return(0);

[Sgt-Nukem]

The original implementation could have been an optimisation, if the checks that follow were expensive to perform, allowing the function to return early before incurring that cost -- however this is probably irrelevant in 2020.

And even now one could get it back by simply swapping !damage to the front and early-out that way:

if ( !damage || Special.IsInert || warhead == WARHEAD_NONE ) return(0);