MinGW-w64 fixes #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed the compiler error on Apple Clang, all tests are looking to pass. |
Use pthreads instead of the win32 threads implementation, as SEH exceptions are poorly supported.
|
@rparolin This hasn't seen activity in almost 2 months. Could you take a look at it, or close the request if you don't intend to merge it? Thanks! |
|
@grojo-ea I noticed you have been merging code into EASTL, I would appreciate it if you could take a look at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I made MinGW-w64 compilers work again with EAThread.
I opted for using pthreads, as those are native to MinGW-w64 and GCC has no support for SEH intrinsics, such as
__tryand__catch.I tested this with GCC, Clang, MSVC, and Clang-CL, but I can't remember if I tested it on Linux.
If possible I'd like to extend EAThread to be numa-aware somewhere in the future, so that MinGW users can make use of all threads on new high core count CPUs. I'm assuming the MSVC side is already numa aware.
As usual, let me know if there are any issues with the PR :)