Skip to content

Commit

Permalink
fix: filter out useless helm messages to slack
Browse files Browse the repository at this point in the history
Useful messages were getting truncated as a result.
  • Loading branch information
Brian May committed Oct 18, 2024
1 parent 86b64b9 commit 4f68d2f
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion src/output/slack.rs
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,15 @@ struct VersionResult<'a> {
upstream_version: String,
}

fn filter_stderr(s: &str) -> String {
// Filter out useless messages from HELM, so good messages don't get truncated.
s.lines()
.filter(|line| !line.starts_with("Pulled: "))
.filter(|line| !line.starts_with("Digest: "))
.collect::<Vec<&str>>()
.join("\n")
}

fn truncate(s: &str, max_chars: usize) -> &str {
match s.char_indices().nth(max_chars) {
None => s,
Expand Down Expand Up @@ -406,7 +415,8 @@ impl SlackState {
blocks.push(block.into());
}

let string = truncate(hr.stderr(), 150);
let stderr = filter_stderr(hr.stderr());
let string = truncate(&stderr, 150);
if !string.is_empty() {
let string = format!("```{string}```\n");
let markdown = SlackBlockMarkDownText::from(string);
Expand Down

0 comments on commit 4f68d2f

Please sign in to comment.