Compile with Android SDK api 35 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
changed the title
github-actions
bot
removed
the
Record-Screenshots
|
jmartinesp
approved these changes
Feb 3, 2025
bmarty
commented
Feb 3, 2025
There was a problem hiding this comment.
The windows icon has a better rendering, not sure why
Other screenshot diff are related to the font letter spacing AFAICT.
There was a problem hiding this comment.
Oh, I completely missed that one. But yeah, it's way better now. Maybe it was a robolectric glitch with vector icons.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
=======================================
Coverage 84.11% 84.11%
=======================================
Files 23 23
Lines 2821 2821
Branches 252 252
=======================================
Hits 2373 2373
Misses 221 221
Partials 227 227 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: will unblock #120