Skip to content

Conversation

@S7evinK
Copy link
Collaborator

@S7evinK S7evinK commented Nov 10, 2025

This is to complement the existing Purge Room Admin API

Pull Request Checklist

@S7evinK S7evinK requested a review from a team as a code owner November 10, 2025 10:24
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 36.11111% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.24%. Comparing base (e546df2) to head (3df3278).

Files with missing lines Patch % Lines
clientapi/routing/admin.go 0.00% 12 Missing ⚠️
roomserver/storage/shared/storage.go 62.50% 3 Missing and 3 partials ⚠️
clientapi/routing/routing.go 25.00% 2 Missing and 1 partial ⚠️
roomserver/internal/perform/perform_admin.go 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (36.11%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3663      +/-   ##
==========================================
+ Coverage   49.45%   52.24%   +2.79%     
==========================================
  Files         524      524              
  Lines       60133    48412   -11721     
==========================================
- Hits        29739    25295    -4444     
+ Misses      26908    19610    -7298     
- Partials     3486     3507      +21     
Flag Coverage Δ
unittests 52.24% <36.11%> (+2.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

// EmptyRooms returns all rooms that the local server has left.
func (d *Database) EmptyRooms(ctx context.Context) ([]string, error) {
// Get all rooms with m.room.member events, which should be all rooms we know about
eventTypeNID, err := d.GetOrCreateEventTypeNID(ctx, spec.MRoomMember)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: this is not needed, as m.room.member is always 5. (Unless someone fiddled with the DB..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants