Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CallViewModel #2629

Merged
merged 15 commits into from
Sep 19, 2024
Merged

Test CallViewModel #2629

merged 15 commits into from
Sep 19, 2024

Commits on Sep 6, 2024

  1. Enable test isolation

    I had experimented with turning this off in order to improve test performance, and apparently that ended up being merged. Now if we're to do component testing, we'll be changing things globally on the document, so isolation is very much necessary.
    robintown committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    251918a View commit details
    Browse the repository at this point in the history
  2. Upgrade Compound Web

    This patch release fixes a bug where tooltips would label non-interactive triggers in an inaccessible way.
    robintown committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    40fc1aa View commit details
    Browse the repository at this point in the history
  3. Test RoomHeaderInfo

    robintown committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d9333d6 View commit details
    Browse the repository at this point in the history
  4. Test InviteModal

    robintown committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0c0be8a View commit details
    Browse the repository at this point in the history
  5. Test GridTile

    robintown committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ba36cfa View commit details
    Browse the repository at this point in the history
  6. Test SpotlightTile

    robintown committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    982bd6d View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Configuration menu
    Copy the full SHA
    fa36fcd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8872b87 View commit details
    Browse the repository at this point in the history
  3. Test SpotlightTile more thoroughly

    Catching two accessibility issues along the way: we were putting the wrong accessible labels on the 'expand' button, and even the off-screen pages of the spotlight tile were being exposed to accessibility technologies rather than hidden.
    robintown committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d6985e0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e8278b4 View commit details
    Browse the repository at this point in the history
  5. Test StarRating

    robintown committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d12a01b View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Test CallViewModel

    This adds tests for a couple of the less trivial bits of code in CallViewModel. Testing them helped me uncover why focus switches still weren't being smooth! (It was because I was using RxJS's sample operator when I really wanted withLatestFrom.)
    robintown committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    016ba67 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Configuration menu
    Copy the full SHA
    156f1e3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    25193f4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4aab6cf View commit details
    Browse the repository at this point in the history