-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test CallViewModel #2629
Merged
Merged
Test CallViewModel #2629
Commits on Sep 6, 2024
-
I had experimented with turning this off in order to improve test performance, and apparently that ended up being merged. Now if we're to do component testing, we'll be changing things globally on the document, so isolation is very much necessary.
Configuration menu - View commit details
-
Copy full SHA for 251918a - Browse repository at this point
Copy the full SHA 251918aView commit details -
This patch release fixes a bug where tooltips would label non-interactive triggers in an inaccessible way.
Configuration menu - View commit details
-
Copy full SHA for 40fc1aa - Browse repository at this point
Copy the full SHA 40fc1aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9333d6 - Browse repository at this point
Copy the full SHA d9333d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c0be8a - Browse repository at this point
Copy the full SHA 0c0be8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba36cfa - Browse repository at this point
Copy the full SHA ba36cfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 982bd6d - Browse repository at this point
Copy the full SHA 982bd6dView commit details
Commits on Sep 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fa36fcd - Browse repository at this point
Copy the full SHA fa36fcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8872b87 - Browse repository at this point
Copy the full SHA 8872b87View commit details -
Test SpotlightTile more thoroughly
Catching two accessibility issues along the way: we were putting the wrong accessible labels on the 'expand' button, and even the off-screen pages of the spotlight tile were being exposed to accessibility technologies rather than hidden.
Configuration menu - View commit details
-
Copy full SHA for d6985e0 - Browse repository at this point
Copy the full SHA d6985e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8278b4 - Browse repository at this point
Copy the full SHA e8278b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d12a01b - Browse repository at this point
Copy the full SHA d12a01bView commit details
Commits on Sep 12, 2024
-
This adds tests for a couple of the less trivial bits of code in CallViewModel. Testing them helped me uncover why focus switches still weren't being smooth! (It was because I was using RxJS's sample operator when I really wanted withLatestFrom.)
Configuration menu - View commit details
-
Copy full SHA for 016ba67 - Browse repository at this point
Copy the full SHA 016ba67View commit details
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 156f1e3 - Browse repository at this point
Copy the full SHA 156f1e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25193f4 - Browse repository at this point
Copy the full SHA 25193f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4aab6cf - Browse repository at this point
Copy the full SHA 4aab6cfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.