Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements for reaction rendering #2749

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Small improvements for reaction rendering #2749

merged 4 commits into from
Nov 11, 2024

Conversation

Half-Shot
Copy link
Member

This fixes:

  • Reactions bumping the layout in 1:1 view. The reactions are now in a container component.
  • Reaction buttons should now scale down on smaller viewports.

This also should bump the test coverage a smidge, as this tests reaction rendering in the new class.

@Half-Shot Half-Shot requested a review from a team as a code owner November 11, 2024 12:09
@Half-Shot
Don't adjust reaction time.
6830744 
That was just for testing
@robintown robintown merged commit 2946950 into livekit Nov 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robintown robintown robintown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @robintown