-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reactions to new design #2751
Conversation
What is the reason for the yaxis asymmetry here:
To me it just looks off that the icons are not y centered |
src/room/InCallView.module.css
Outdated
@media (max-width: 660px) { | ||
.footer { | ||
grid-template-areas: ". buttons buttons buttons ."; | ||
} | ||
|
||
.logo { | ||
display: none; | ||
} | ||
|
||
.layout { | ||
display: none !important; | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this will regress #2754
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a case of Ctrl-X
rather than Ctrl-C
This has not yet been addressed: #2751 (comment) Maybe it would be interesting to explore adding some react spring (or maybe a css transition is enough) to open and close the expanded/non expanded panel? |
That chunk didn't seem to be making any visual difference so removed it. I'm afraid my eyes might be failing me, but it looks y centered to me. |
I think we still need to reduce it to:
otherwise we get the dialog default of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice.
What do you think about the idea of making the open/close of the reactions animated?
I also think the disabled state is a bit unfortunate (with the grey bg)
It would be nice if the icon would be a bit transparent...
But It seems we are just passing disabled to compound so this probably should not be done here.
@Half-Shot I also think we can do a shortcut:
|
I had a look at animating it, but it is a bit of a faff with the dialog present. I'll do a draft PR with some animations to follow this up. The disabled state is a bit unfortunate, yeah. I think it's a compound problem yep. |
it its not as easy as addin a css tanstition duration we should not bother too much about it! |
https://www.figma.com/design/fq7cTHPNHZX3ttFW1gBEnv/Compound-Element-Call?node-id=3503-20185&node-type=frame&t=wxQhSaTWeyrvUxhq-0
Needs tests still.