-
Notifications
You must be signed in to change notification settings - Fork 136
Add keyboard shortcut disable setting #3621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: livekit
Are you sure you want to change the base?
Conversation
robintown
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are keyboard shortcuts in ReactionToggleButton.tsx as well (and we should probably hide the shortcut hints from the tooltips if they're disabled)
| "preferences_tab": { | ||
| "developer_mode_label": "Developer mode", | ||
| "developer_mode_label_description": "Enable developer mode and show developer settings tab.", | ||
| "enable_keyboard_shortcuts_description": "Use keyboard shortcuts to control Element Call.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The product name is configurable so it'll need to be templated in
|
@erikjohnston feedbacks that he's a difficult (reasonable) person who would like to have shortcuts for muting/unmuting and actions but the numeric reaction buttons are annoying. I'm actually wondering if we just drop them, do they feel useful? |
that is something for product. And note that the shortcut situation is a bit weird as: |
For context: I heavily rely on desktop shortcuts that involve numerals (either switching chrome tabs or linux workspaces), and I semi-frequently trigger reactions by accident due to mistyping the shortcuts. This is obviously quite bad as it triggers spurious noise on everyone who is on the call (whereas e.g. the mute/unmute buttons only have local affect so it matters less if you accidentally mute/unmute yourself, assuming you notice). While being able to disable shortcuts for reactions would help me, I think reaction shortcuts should be harder to trigger (e.g. by adding a modifier key), given a) the impact and b) numeral shortcuts are commonly used. |
Not everyone loves a keyboard shortcut, so allow disabling them if you are not a fan.