Skip to content

Conversation

@Half-Shot
Copy link
Member

Not everyone loves a keyboard shortcut, so allow disabling them if you are not a fan.

@Half-Shot Half-Shot requested a review from a team as a code owner December 5, 2025 16:44
@Half-Shot Half-Shot added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Dec 5, 2025
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are keyboard shortcuts in ReactionToggleButton.tsx as well (and we should probably hide the shortcut hints from the tooltips if they're disabled)

"preferences_tab": {
"developer_mode_label": "Developer mode",
"developer_mode_label_description": "Enable developer mode and show developer settings tab.",
"enable_keyboard_shortcuts_description": "Use keyboard shortcuts to control Element Call.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product name is configurable so it'll need to be templated in

@Half-Shot
Copy link
Member Author

@erikjohnston feedbacks that he's a difficult (reasonable) person who would like to have shortcuts for muting/unmuting and actions but the numeric reaction buttons are annoying.

I'm actually wondering if we just drop them, do they feel useful?

@fkwp
Copy link
Contributor

fkwp commented Dec 9, 2025

@erikjohnston feedbacks that he's a difficult (reasonable) person who would like to have shortcuts for muting/unmuting and actions but the numeric reaction buttons are annoying.

I'm actually wondering if we just drop them, do they feel useful?

that is something for product. And note that the shortcut situation is a bit weird as:
if EC widget is in foreground the messenger shortcuts are not working and vice versa.

cc @daniellekirkwood

@erikjohnston
Copy link
Member

@erikjohnston feedbacks that he's a difficult (reasonable) person who would like to have shortcuts for muting/unmuting and actions but the numeric reaction buttons are annoying.

I'm actually wondering if we just drop them, do they feel useful?

For context: I heavily rely on desktop shortcuts that involve numerals (either switching chrome tabs or linux workspaces), and I semi-frequently trigger reactions by accident due to mistyping the shortcuts. This is obviously quite bad as it triggers spurious noise on everyone who is on the call (whereas e.g. the mute/unmute buttons only have local affect so it matters less if you accidentally mute/unmute yourself, assuming you notice).

While being able to disable shortcuts for reactions would help me, I think reaction shortcuts should be harder to trigger (e.g. by adding a modifier key), given a) the impact and b) numeral shortcuts are commonly used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants