Delay snapshotting various flakey UI tests

[stefanceriu]

• as per https://app.codecov.io/gh/element-hq/element-x-ios/tests/develop?historicalTrend=INTERVAL_30_DAY&parameter=FAILED_TESTS

We've been getting quite a few failures on AppLockSetupUITests but there's nothing obviously wrong with them. Running them repeatedly locally though eventually results in random snapshotting failures, which might very well be the real reason.

As such I went and added delays to all the UI tests that have been reported as flakey on Codecov 🤞

[pixlwave]

Heh, I didn't realise/forgot that second parameter was even there 🙈

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[pixlwave]

Note: I don't think this is going to fix the AppLock tests though. They're not failing with bad snapshots, they're failing with weird lock-ups that cause the test to time-out:

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
908	1	907	0

View the full list of 1 ❄️ flaky tests

PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 13.04% (Passed 120 times, Failed 18 times)

Stack Traces | 1.97s run time

failed - Snapshot "Ignored User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Ignored-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Ignored-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8309326 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:85)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!