Add experimental support for MSC4222 #17888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't actually change what we return in `state_after` yet.
Closed
4 tasks
Co-authored-by: Andrew Morgan <[email protected]>
anoadragon453
approved these changes
Nov 5, 2024
erikjohnston
added a commit
that referenced
this pull request
Nov 8, 2024
There was a bug that meant we would return the full state of the room on incremental syncs when using lazy loaded members and there were no entries in the timeline. This was due to trying to use `state_filter or state_filter.all()` as a short hand for handling `None` case, however `state_filter` implements `__bool__` so if the state filter was empty it would be set to full. c.f. MSC4222 and #17888
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, if the client sets a special query param on
/syncv2 instead of responding withstateat the start of the timeline, we instead respond withstate_afterat the end of the timeline.We do this by using the
current_state_delta_streamtable, which is actually reliable, rather than messing around with "state at" points on the timeline.c.f. MSC4222
Reviewable commit-by-commit.