Enable authenticated media by default #17889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
when we land this, would be good to update the doc to say which version the default changed in |
There was a problem hiding this comment.
We should shout about this change in the relevant release version's upgrade notes.
reivilibre
added a commit
to matrix-org/complement
that referenced
this pull request
Nov 18, 2024
This fixes support with homeservers that enforce authenticated media, such as Synapse in element-hq/synapse#17889
1 task
reivilibre
added a commit
to matrix-org/complement
that referenced
this pull request
Nov 19, 2024
This will be expected to fail when Synapse enforces authenticated media by default in element-hq/synapse#17889
1 task
reivilibre
force-pushed
the
travis/auth-always-on
branch
from
fa66b4f to
fc5d31c
Compare
reivilibre
added a commit
to matrix-org/complement
that referenced
this pull request
Nov 19, 2024
This will be expected to fail when Synapse enforces authenticated media by default in element-hq/synapse#17889
erikjohnston
approved these changes
Nov 20, 2024
reivilibre
added a commit
to matrix-org/complement
that referenced
this pull request
Nov 20, 2024
This fixes support with homeservers that enforce authenticated media, such as Synapse in element-hq/synapse#17889
reivilibre
added a commit
to matrix-org/complement
that referenced
this pull request
Nov 20, 2024
These will be expected to fail when Synapse enforces authenticated media by default in element-hq/synapse#17889
|
I just realized this had broken all my images and only swithing it to false fixed things. I don't have knowledge enough to figure out why, but every single URL of my images showed Why this change and what it does? I'm using synapse-s3-storage-provider, is this taken into account? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to delay landing this PR as the team sees fit.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)