Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue one time keys in upload order #17903

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Issue one time keys in upload order #17903

wants to merge 2 commits into from

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Nov 4, 2024

Currently, one-time-keys are issued in a somewhat random order. (In practice, they are issued according to the lexicographical order of their key IDs.) That can lead to a situation where a client gives up hope of a given OTK ever being used, whilst it is still on the server.

Fixes: element-hq/element-meta#2356

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

Currently, one-time-keys are issued in a somewhat random order. (In practice,
they are issued according to the lexicographical order of their key IDs.) That
can lead to a situation where a client gives up hope of a given OTK ever
being used, whilst it is still on the server.

Fixes: element-hq/element-meta#2356
@richvdh richvdh requested a review from a team as a code owner November 4, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clients may throw away one-time keys which are still published on the server, or have messages in flight
1 participant