Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macaroon_secret_key_path config option #17983

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

V02460
Copy link
Contributor

@V02460 V02460 commented Dec 2, 2024

Another config option on my quest to a *_path variant for every secret. This time it’s macaroon_secret_key_path.

Slightly modified the tests to accommodate for this option (see 9367d18, 087ec0f), hopefully self-explanatory.

Reading secrets from files has the security advantage of separating the secrets from the config. It also simplifies secrets management in Kubernetes. Also useful to NixOS users.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@V02460 V02460 requested a review from a team as a code owner December 2, 2024 15:02
@github-actions github-actions bot deployed to PR Documentation Preview December 2, 2024 15:03 Active
@MadLittleMods MadLittleMods changed the title Add macaroon_secret_key_path config option Add macaroon_secret_key_path config option Dec 16, 2024
@github-actions github-actions bot deployed to PR Documentation Preview December 16, 2024 23:22 Active
@MadLittleMods MadLittleMods merged commit 57bf449 into element-hq:develop Dec 17, 2024
41 checks passed
@MadLittleMods
Copy link
Contributor

Thanks for continuing down the path @V02460 🐡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants