Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reverse proxy docs with what we've learned from #17986 #17994

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Update reverse proxy docs with what we've learned from #17986 #17994

merged 2 commits into from
Dec 19, 2024

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Dec 4, 2024 •
edited
Loading

Update reverse proxy docs with what we've learned from #17986

Also vice versa and update our nginx config with what I learned from the reverse proxy docs.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@github-actions github-actions bot deployed to PR Documentation Preview December 4, 2024 01:18 Active
MadLittleMods
MadLittleMods commented Dec 4, 2024
View reviewed changes
docker/conf-workers/nginx.conf.j2
Comment on lines +41 to +43
# note: do not add a path (even a single /) after the port in `proxy_pass`,
# otherwise nginx will canonicalise the URI and cause signature verification
# errors.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment comes from our reverse_proxy.md docs.

What I think it actually means -> https://stackoverflow.com/questions/16157893/nginx-proxy-pass-404-error-dont-understand-why/62753212#62753212

MadLittleMods
MadLittleMods commented Dec 4, 2024
View reviewed changes
docs/reverse_proxy.md
@@ -74,7 +74,7 @@ server {
proxy_pass http://localhost:8008;
proxy_set_header X-Forwarded-For $remote_addr;
proxy_set_header X-Forwarded-Proto $scheme;
proxy_set_header Host $host;
proxy_set_header Host $host:$server_port;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating our docs to match what we fixed in #17986

@MadLittleMods MadLittleMods marked this pull request as ready for review December 4, 2024 17:47
@MadLittleMods MadLittleMods requested a review from a team as a code owner December 4, 2024 17:47
anoadragon453
anoadragon453 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this will save folks quite a lot of time in the future. Thanks for carrying this through to the end!

@anoadragon453 anoadragon453 merged commit bd9a107 into develop Dec 19, 2024
39 checks passed
@anoadragon453 anoadragon453 deleted the madlittlemods/17986-follow-up-docs branch December 19, 2024 14:00
@MadLittleMods
Copy link
Contributor Author

Thanks for the review and merge @anoadragon453 🐍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
A-Docker A-Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MadLittleMods @anoadragon453