-
Notifications
You must be signed in to change notification settings - Fork 425
Allow admins to bypass the quarantine check on media downloads #19275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
this will almost certainly fail the linter, but it's meant to show the changes a bit more clearly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Only main concerns are regarding documentation and debug-ability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some documentation for this somewhere?
Either in the Admin FAQ or a new page about media administration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is? It's on the media administration page in this PR.
Note: this was written using the copy/paste development technique, so may not adhere to great Python standards.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.