-
Notifications
You must be signed in to change notification settings - Fork 160
perf(Thinking): 优化思考组件展开收缩图标 #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe arrow icon in the Thinking component was changed from an upward-pointing to a downward-pointing arrow in both the import and template. Additionally, the Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/core/src/components/Thinking/index.vue (1)
43-43: Address the linting rule conflict.The formatting change conflicts with the ESLint rule
antfu/if-newlinewhich expects a newline after the if statement. Consider either reverting to the multi-line format or updating the linting configuration if this style is preferred.- if (props.disabled) return; + if (props.disabled) + return;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/core/src/components/Thinking/index.vue(3 hunks)
🧰 Additional context used
🪛 ESLint
packages/core/src/components/Thinking/index.vue
[error] 43-43: Expect newline after if
(antfu/if-newline)
🔇 Additional comments (2)
packages/core/src/components/Thinking/index.vue (2)
8-8: LGTM! Icon import updated correctly.The change from
ArrowUpBoldtoArrowDownBoldaligns with the PR objective to improve the expand/collapse icon accuracy.
129-129: Excellent UX improvement!The icon change to
ArrowDownBoldproperly implements the expand/collapse state indication. With theexpandedCSS class (line 125), this creates intuitive behavior where:
- Collapsed state: down arrow (▼) indicates "click to expand down"
- Expanded state: rotated up arrow (▲) indicates "click to collapse up"
This directly addresses the PR objective of fixing icon direction accuracy.
优化 Thinking 组件展开收缩图标显示不够准确问题,如图豆包与deepseek展开时箭头应该向上
Summary by CodeRabbit