New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application: Close the window on quit, don't destroy it #2201

Merged

tintou merged 1 commit into main from leolost/quit-close-not-destroy

Jul 18, 2024

Member

leolost2605 commented Jul 18, 2024

Destroying causes our cleaup in close_request to not run


          Application: Close the window on quit, don't destroy it

9b6ea35

leolost2605 requested review from zeebok and a team

July 18, 2024 10:50

leolost2605 mentioned this pull request

Quit keyboard shortcut closes the window but not the application #2198

Closed

tintou approved these changes

View reviewed changes

tintou merged commit 20f2bb1 into main

2 of 4 checks passed

tintou deleted the leolost/quit-close-not-destroy branch

July 18, 2024 11:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet