-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add instant-tooltips functionality #33
Conversation
Needs UX team approval for adding another setting. |
Shouldn't this "Instant Tooltips" switch be in Behaviour tab? |
Yes, Behavior tab makes sense to me. I'm also not stuck on the name 'Instant Tooltips' I just wanted to make the dock behave a certain way and I had to call it something. 😄 I'll wait for the UX team to give me feedback before I make any more changes. If they are open to this chnage then options may also need to be made to the pantheon-shell switchboard plug. |
Also, I noticed that when I reboot the feature is automatically switched off. I would like to figure out how to make this option stick. Currently I run 'plank --preferences' after rebooting. |
@cassidyjames what do you think of this PR / issue #29 ? |
I'm not sure separate tooltip behavior makes sense here compared to whatever GTK gives us by default, but I see that plank isn't even using GTK tooltips. So I'm not sure. I don't think another setting is really the right approach, though—I think either the tooltips should be actual GTK tooltips (or as similar as possible), or they should be distinct if there's a good reason to do so. I don't think a user should have to make that decision. |
I understand that this may just be my preference, but maybe other users feel the same? If it helps, the dash in gnome only seems to have a delay until the initial tooltip is shown After that it shows them immediately. I have not used OS/X in a long time but from my memory there is no delay on that dock whatsoever. Not that it matters, but having to stop the mouse over each icon was tedious enough (to me) to motivate me to take a look at the code and draft a PR. 🤓 |
@cassidyjames Is this likely to be accepted? To me the existing delay is small enough not to be a material issue. |
Converting to draft as there are unresolved design issues that need deciding before the code can be reviewed. In my view, the speed of tooltip display should be optimized as a design decision and should not be a setting. |
Just my two cents, I'd rather have a switch for tooltips on/off, on being instant tooltips and off being no tooltips. |
Closing since this is based on the old plank codebase |
addresses #29