wayland: Launch notifications server as a wayland client #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/gala into leolost/wayland-notifications
|
With mutter <46 there is still focus stealing going on however that will be fixed in 46 |
leolost2605
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
ShellClientManagerthat currently only creates the notificationsclient. However we will need something like this anyways for the wayland protocol since all clients that want to use it (or at least the panel/dock parts of it) have to be launched as wayland clients.I'll also try to migrate the daemonmanager to
ManagedClientas well in a future PR.This also helps to keep the code added to WindowManager as little as possible by taking responsibility from it compared to #1863 since it's already a huge class anyways.
Closes #1863
Fixes #1693
Going the route of the
NOTIFICATION_DATA_KEYis a bit of a workaround and once I have some more time i'll try to get something like make_notification merged in upstream mutter however since AFAIK we now are too late for 46 anyways that would be OS 9 material and I think the few lines of code are good enough for now.Any feedback regarding this approach especially with consideration of the upcoming wayland protocol etc. is much appreciated :)