ShellClients: Don't make centered clients docks but allow their shortcut inhibition without dialog #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
reviewed
Jul 20, 2024
| @@ -229,8 +229,9 @@ namespace Gala { | |||
| return; | |||
| } | |||
|
|
|||
| // Naive check to always allow inhibiting by our settings app. This is needed for setting custom shortcuts | |||
| if (app.id == "io.elementary.settings.desktop") { | |||
| if (app.id == "io.elementary.settings.desktop" || // Naive check to always allow inhibiting by our settings app. This is needed for setting custom shortcuts | |||
There was a problem hiding this comment.
While we're here should we just do prefix of io.elementary?
tintou
reviewed
Jul 20, 2024
tintou
reviewed
Jul 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1994
We don't really need the focus method now anymore, should we remove it too? Or might it come in handy at some other point in the future?