-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShellClients: Allow X11 clients to use pantheon protocol via mutter hints #2002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's way cleaner then using dbus. Thank you. Still waiting for @tintou review.
Co-authored-by: Leo <[email protected]>
Also, I noticed that this PR doesn't allow using Gtk4 notifications server in X11. If we will use this approach with mutter hints, we will have to add a new parameter or something like that to identify the windows. But we can deal with that later. |
I think regarding the notifications server we can just use the x library to set our window type as notification just like the gtk3 version does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 🎉
Fixes #1965
Closes #1997
Has the same functionality as #1997 but uses the x property _MUTTER_HINTS