Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShellClients: Allow X11 clients to use pantheon protocol via mutter hints #2002

Merged
merged 8 commits into from
Aug 8, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Jul 27, 2024

Fixes #1965
Closes #1997

Has the same functionality as #1997 but uses the x property _MUTTER_HINTS

Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's way cleaner then using dbus. Thank you. Still waiting for @tintou review.

src/ShellClients/ShellClientsManager.vala Outdated Show resolved Hide resolved
src/ShellClients/ShellClientsManager.vala Outdated Show resolved Hide resolved
src/ShellClients/ShellClientsManager.vala Outdated Show resolved Hide resolved
@leolost2605 leolost2605 requested a review from tintou August 1, 2024 18:31
@danirabbit danirabbit requested a review from lenemter August 2, 2024 18:55
src/ShellClients/ShellClientsManager.vala Outdated Show resolved Hide resolved
src/ShellClients/ShellClientsManager.vala Outdated Show resolved Hide resolved
@lenemter
Copy link
Member

lenemter commented Aug 8, 2024

Also, I noticed that this PR doesn't allow using Gtk4 notifications server in X11. If we will use this approach with mutter hints, we will have to add a new parameter or something like that to identify the windows. But we can deal with that later.

@leolost2605
Copy link
Member Author

I think regarding the notifications server we can just use the x library to set our window type as notification just like the gtk3 version does

Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 🎉

@lenemter lenemter merged commit df5cb17 into main Aug 8, 2024
2 of 4 checks passed
@lenemter lenemter deleted the leolost/pantheon-protocol-x11 branch August 8, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Launch Dock on X11
4 participants