Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PiP: Fix shadow #2005

Merged
merged 4 commits into from
Aug 3, 2024
Merged

PiP: Fix shadow #2005

merged 4 commits into from
Aug 3, 2024

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Aug 3, 2024

Fixes missing shadow from #1617

@lenemter lenemter requested a review from a team August 3, 2024 06:22
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that indeed this fixes the shadow. Nice work

@danirabbit danirabbit merged commit 2396f7f into main Aug 3, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the lenemter/fix-pip-shadow branch August 3, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants