WindowClone: Layout in allocate virtual

[leolost2605]

Currently we are doing most of the layout management by hardcoding x, y, width and height of our child actors. However we can make the whole thing simpler and more robust by doing the layout management in the allocate virtual method as recommended by clutter docs.

Since the root cause for the following issues was that we didn't allocate some children on rare occasions which was fixed in this PR this
fixes #2053 and
fixes #1898 and therefore
closes #2072

There are still some issues when windows spawn while multitasking view is open (like for example they reserve space but don't show) that I would like to tackle in follow up PRs but at least it doesn't completely break anymore as on current main :)

fixes #2088 by reverting #2072

Fixes #2128

[danirabbit]

I can confirm that this fixes the linked issues, but it looks like the textures (window clones, close buttons, app icons) are all rendered half a pixel offset so they're blurry (this is on LoDPI and Wayland)

[danirabbit]

Tooltips also appear to be cut off and text looks pretty gnarly. Although when I went back to get a screenshot the other textures all look aligned correctly here 🤔

This branch:

main:

[leolost2605]

@danirabbit the allocations are clamped to pixels now could you try again with that? I'm not so good at noticing those differences 😅
(and the tooltip thing I don't seem to be able to reproduce, probably requires a very specific window size and name 🤷)

[leolost2605]

So fedora is failing because for some reason it compiles with stricter rules (?) about implicit function declaration and clutter_actor_get_relative_transformation_matrix is defined in clutter-mutter.h and not clutter.h which we don't include anywhere. And we can't include it because it pulls in _private headers that aren't shipped. At least that's what I figured maybe I'm wrong somewhere :)
See comment below

[leolost2605]

Nvm I found a utility method that's much better to use in this case and properly exported :)

[lenemter]

@leolost2605 Is this ready for review? I really want to include this in 8.0.4 release.

One thing I noticed is that clone no longer has magnifying filters? clone.set_content_scaling_filters (Clutter.ScalingFilter.TRILINEAR, Clutter.ScalingFilter.TRILINEAR); seems to fix this.

[leolost2605]

@lenemter yes it's ready.

I've added the filters although TBH i don't really know what they do 😅

[tintou]

Opened https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4156 for your missing includes…

[leolost2605]

Thank you!

[lenemter]

Looks great, one small issue in the code, after that should be ready to go

[lenemter]

@danirabbit Can you review this branch please?

[danirabbit]

Everything looks sharp but it looks like this re-introduces the issue where windows that spawn while multitasking view is open aren't added. To reproduce:

1. Open screenshot and set a timed screenshot
2. Open multitasking view
3. when the timer runs out the new window will be transparent with no icon tooltip etc

[leolost2605]

There are still some issues when windows spawn while multitasking view is open (like for example they reserve space but don't show) that I would like to tackle in follow up PRs but at least it doesn't completely break anymore as on current main :)

From the description (the breaking refers to the version before the workaround was merged)

If it's a must I can do it here though 🤷

[danirabbit]

Ah sorry I missed that. In that case 👍 😀