-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Super+Scroll actions #2165
Add Super+Scroll actions #2165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really really love this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought I think it might be better to make the void triggered ()
signal a bool triggered ()
, return that for propagation and have everything that needs a super scroll action add their own. This would stay more in line with how events, etc. are generally handled and avoids having to add even more api to the windowmanager.
What do you think?
@leolost2605 we need to implement our own objects hierarchy for this to make sense. I think having one signal and allow anyone to connect to it is simple and shouldn't produce any issues when used correctly. |
I'm not sure I understand what you mean here? |
How are we gonna propagate the signal in this case? It's not an event, so we can't use Clutter... TBH I don't understand exactly what you mean in your original comment. |
I meant something like the last commit in #2182 does. |
Fixes #815
Fixes #1178
Closes elementary/switchboard-plug-mouse-touchpad#215