Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Super+Scroll actions #2165

Closed
wants to merge 11 commits into from
Closed

Add Super+Scroll actions #2165

wants to merge 11 commits into from

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Dec 13, 2024

@lenemter lenemter requested a review from a team December 13, 2024 14:02
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really really love this!

src/WindowManager.vala Outdated Show resolved Hide resolved
@lenemter lenemter requested a review from leolost2605 December 13, 2024 14:43
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought I think it might be better to make the void triggered () signal a bool triggered (), return that for propagation and have everything that needs a super scroll action add their own. This would stay more in line with how events, etc. are generally handled and avoids having to add even more api to the windowmanager.
What do you think?

@lenemter
Copy link
Member Author

@leolost2605 we need to implement our own objects hierarchy for this to make sense. I think having one signal and allow anyone to connect to it is simple and shouldn't produce any issues when used correctly.

@lenemter lenemter requested a review from leolost2605 December 18, 2024 19:54
@leolost2605
Copy link
Member

@leolost2605 we need to implement our own objects hierarchy for this to make sense

I'm not sure I understand what you mean here?

@lenemter
Copy link
Member Author

How are we gonna propagate the signal in this case? It's not an event, so we can't use Clutter... TBH I don't understand exactly what you mean in your original comment.

@leolost2605
Copy link
Member

leolost2605 commented Dec 19, 2024

I meant something like the last commit in #2182 does.
Feel free to give your opinion :)

@lenemter lenemter closed this Dec 19, 2024
@lenemter lenemter deleted the lenemter/super-scroll branch December 19, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants