Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowManager: Only show notifications after their window was shown #2183

Merged
merged 6 commits into from
Dec 21, 2024

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Dec 19, 2024

Fixes #2175
Fixes #2102

Closes #2129

Now InternalUtils.wait_for_window_actor is basically the same as Meta.Window.shown

@lenemter lenemter requested a review from a team December 19, 2024 21:05
src/InternalUtils.vala Outdated Show resolved Hide resolved
src/InternalUtils.vala Outdated Show resolved Hide resolved
@lenemter lenemter requested a review from leolost2605 December 20, 2024 13:36
src/InternalUtils.vala Outdated Show resolved Hide resolved
@lenemter lenemter requested a review from leolost2605 December 21, 2024 09:05
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue. Good job and thanks for the in depth investigation!

@leolost2605 leolost2605 enabled auto-merge (squash) December 21, 2024 16:32
@leolost2605 leolost2605 merged commit 84a1352 into main Dec 21, 2024
5 checks passed
@leolost2605 leolost2605 deleted the lenemter/fix-notifications-crash branch December 21, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants