Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gestures: Introduce GestureAction #2186

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Dec 21, 2024

Instead of presenting the consumers of gestures with all the details about the gesture we just give them the action that should be triggered, and whether we should go forward (e.g. switch to the left with workspace switches or open the multitasking view) or backward (the opposite).

This helps

  1. with memory since we have to store less values (negligible but nice to have ig :)))
  2. with performance because we don't have to call GestureSettings.get_action twice in e.g. WindowManager
  3. with lines of code
  4. with preparation for more deduplication between one to one gestures and e.g. keyboard "gestures"

So win, win, win, win I guess? Let me know what you think :)

@leolost2605 leolost2605 requested a review from a team December 21, 2024 16:23
@leolost2605 leolost2605 mentioned this pull request Dec 21, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant