Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Move panel hiding to shellclients from multitaskingview #2193

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Dec 24, 2024

Includes #2192.

Same as #2150 but cleaned up for a rebase instead of squash for easier review

The additional changes here on top of #2192 are:

  • Introduce a shell_group clutter actor that will be the parent of all shell UI WindowActors (e.g. panels, notifications, centered windows, etc.). This has the advantage that we have full control when and above what we show these. For example with this we can fix Can't open the applications menu when on fullscreen #2130, have wingpanel and dock interactable in the windowoverview (currently they show but you can't do anything with them) or eventually we can keep e.g. the dock visible and interactable in the multitasking view.
  • Introduce a ShellClients.set_force_hide_panels to have all hiding/showing be done in the ShellClients instead of having the multitasking view do their own thing. This has to be done together with the shell group or else we get duplicate dock clones, etc.

Closes #2192 if merged before it.

@leolost2605 leolost2605 requested a review from a team December 24, 2024 11:34
@leolost2605 leolost2605 mentioned this pull request Dec 24, 2024
15 tasks
@leolost2605
Copy link
Member Author

Converting to draft real quick because I think splitting the multitasking view change and the shell group change is probably worth it :)

@leolost2605 leolost2605 marked this pull request as draft December 25, 2024 20:48
@leolost2605 leolost2605 changed the title Shell group WIP: Move panel hiding to shellclients from multitaskingview Dec 25, 2024
@leolost2605 leolost2605 removed the request for review from a team December 25, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't open the applications menu when on fullscreen
1 participant