Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot: Fix the interactive dialog being visible in screenshots of the entire screen #109

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Screenshot: Fix the interactive dialog being visible in screenshots of the entire screen #109

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd75007
Screenshot: Fix the interactive dialog being visible in fullscreen sc…
leolost2605 Aug 12, 2024
fec776e
Make comment clearer
leolost2605 Aug 12, 2024
b9e4ec0
Make comment even clearer
leolost2605 Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Screenshot/Portal.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,14 +170,16 @@ public class Screenshot.Portal : Object {
cancelled = false;
}

screenshot.callback ();
dialog.destroy ();

// When we close our window, gala fades us out so wait until we are actually not visible anymore
// (The animation duration in gala is currently 195ms)
Timeout.add_once (200, () => screenshot.callback ());
});

dialog.show ();
yield;

dialog.destroy ();

if (cancelled) {
response = 1;
return;
Expand Down
Loading