Access/Dialog: Center and keep above on wayland #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah I forgot this uses request portal! That's great because that makes sense for all of those tbh. I'll have to write packaging for the pantheon lib so marking this as 'blocked' 😅 |
danirabbit
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Ah okay so looking at this more, these request dialogs usually have a parent. I'm guessing that in this case we don't get a parent because it's being called from Gala and not really from system settings. So we probably should make sure we only do center/on top if we don't have a parent window
|
Ah right I forgot about that, fixed it :) |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
danirabbit
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115
Requires elementary/gala#2027 (Otherwise it will crash when closed)