Use changed signal for app updates

elementary · Aug 26, 2023 · 99cac1d · 99cac1d
1 parent f185805
commit 99cac1d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/App.vala b/src/App.vala
@@ -6,6 +6,8 @@
 */
 
 public class Sound.App : Object {
+    public signal void changed ();
+
     public uint32 index { get; private set; }
     public string name { get; private set; }
     public string display_name { get; private set; }

diff --git a/src/AppRow.vala b/src/AppRow.vala
@@ -109,14 +109,12 @@ public class Sound.AppRow : Gtk.Grid {
         app_name_label.label = app.display_name;
         image.set_from_gicon (app.icon, Gtk.IconSize.DND);
 
-        app.notify["volume"].connect (update);
-        app.notify["muted"].connect (update);
+        app.changed.connect (update);
 
         volume_scale.set_value (app.volume);
     }
 
     public void unbind_app () {
-        app.notify["volume"].disconnect (update);
-        app.notify["muted"].disconnect (update);
+        app.changed.disconnect (update);
     }
 }
diff --git a/src/PulseAudioManager.vala b/src/PulseAudioManager.vala
@@ -628,6 +628,8 @@ public class Sound.PulseAudioManager : GLib.Object {
         if (app.volume != volume) {
             app.volume = volume;
         }
+
+        app.changed ();
     }
 
     private void card_info_callback (PulseAudio.Context c, PulseAudio.CardInfo? card, int eol) {