Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APP 705] add connect module, settings and notification component #112

Merged
merged 38 commits into from
Nov 13, 2024
Merged

[APP 705] add connect module, settings and notification component #112

merged 38 commits into from
Nov 13, 2024

Conversation

nirbhayel
Copy link

No description provided.

bainternet and others added 26 commits October 20, 2024 13:30
@bainternet
Initial refactor commit
c5eeb17
@bainternet
✅ Added build and tests CI/CD
c641495
@nirbhayel
update: add src for admin settings
c003cf7
@nirbhayel
update: incorrect constant names
21987b4
@nirbhayel
update: namespace
6333248
@nirbhayel
add: accessibility settings
ebd2df1
@nirbhayel
update: webpack to output files inside a folder
9e3bc10
@nirbhayel
update: build output folders
9757cda
@nirbhayel
update: removed commented code
b0dafef
@nirbhayel
update: npm scripts
2ceabd3
@nirbhayel
add: webpack config
1a87560
@nirbhayel
add: hooks
d0a1b8f
@nirbhayel
update: move admin setting to the module folder
2566690
@nirbhayel
update: assets loading logic
96fec7c
@nirbhayel
update: add rule to move jsx props to multiline imporving readability
32a2057
@nirbhayel
add: connect modal
dcb1245
@nirbhayel
update: hooks import for better readability
a1f7b68
@nirbhayel
update: replace functions with hooks
d6d1ab6
@nirbhayel
add: connect module
8810af3
@nirbhayel
add: settings and get settings route
d6c4efc
@nirbhayel
add: hooks and contexts to get settings
c87250b
@nirbhayel
add: hooks
7938003
@nirbhayel
add: notification component
06e8323
@nirbhayel
add: data api
3c8845e
@nirbhayel
add: settings provider and connect settings
b451dc5
@nirbhayel
add: husky
d89b521
@pkniazevych
Copy link

Can you resolve the conflicts, please @nirbhayel?

@nirbhayel nirbhayel self-assigned this Nov 7, 2024
DinetsV
DinetsV reviewed Nov 7, 2024
View reviewed changes
modules/connect/classes/config.php Outdated Show resolved Hide resolved
modules/connect/classes/config.php Show resolved Hide resolved
modules/connect/classes/config.php Outdated Show resolved Hide resolved
modules/settings/assets/js/app.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
pkniazevych
pkniazevych requested changes Nov 7, 2024
View reviewed changes
Copy link

@pkniazevych pkniazevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, review the comments

pkniazevych
pkniazevych approved these changes Nov 12, 2024
View reviewed changes
Copy link

@pkniazevych pkniazevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bainternet bainternet merged commit 9056e59 into elementor:develop Nov 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DinetsV DinetsV DinetsV left review comments

@bainternet bainternet bainternet left review comments

@pkniazevych pkniazevych pkniazevych approved these changes

Assignees

@nirbhayel nirbhayel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nirbhayel @pkniazevych @bainternet @DinetsV