Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added background class to HTML to fix the grayscale issue #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ivcreative
Copy link

Added the backgrounds classes to the HTML tag of the site, the reason for this is that when the Grayscale option is selected it uses the filter property, this makes the element as a containing block please see reference bellow here:

A value other than none for the filter property results in the creation of a containing block for absolute and fixed positioned descendants unless the element it applies to is a document root element in the current browsing context. The list of functions are applied in the order provided.

I edited the Less file to work as before for every other option but now the grayscale does remain fixed.

I would like to ask if it is possible to collaborate on this project there are certain accessibility issues from the plugin I can help address to make it more compliant.

Some users have requested support to fix this on the plugin page https://wordpress.org/support/topic/grayscale-not-working/.

Hope this helps.

@ivcreative
Copy link
Author

This fix is for #24 and also mentioned in the WordPress Plugin support at https://wordpress.org/support/topic/grayscale-not-working/

@hrvoj3e
Copy link

hrvoj3e commented May 5, 2021

Does this also fix overflow bug?

bug-1

@ivcreative
Copy link
Author

Yes it was mostly to fix the overflow, but I'm changing a little the other options since I had to change the way they work there is one that loses the background on the body almost done with that

@ivcreative
Copy link
Author

ivcreative commented May 5, 2021

Just committed and added to the pull request the final background fixes, this also fixes background images not showing when using the darker contrasts besides the grayscale overflow issue. Fixes #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants