Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Alternate RetryConfigBuilder to group relevant configs together for easier use #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raghavan20
Copy link

  • AlternateRetryConfigBuilder is the alternate implementation
  • Usage is described using AlternateRetryConfigBuilder
  • Contains few config groups
  • Many subclasses are designed mutable for use like Builders
  • Many subclasses could be extracted to become parent level classes in their own files
  • Some classes do use defaults

Please suggest improvements / feel free to change code

@coveralls
Copy link

coveralls commented Sep 6, 2018

Pull Request Test Coverage Report for Build 333

  • 57 of 70 (81.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.09%) to 94.778%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/evanlennick/retry4j/config/AlternateRetryConfigBuilder.java 57 70 81.43%
Totals Coverage Status
Change from base Build 331: -2.09%
Covered Lines: 490
Relevant Lines: 517

💛 - Coveralls

…ser of use

AlternateRetryConfigBuilder is the alternate implementation
Usage is described using AlternateRetryConfigBuilder
contains few config groups
Many subclasses are designed mutable for use like Builders
Many subclasses could be extracted to become parent level classes in
 their own files
@raghavan20 raghavan20 force-pushed the alternate-api-for-retryconfigbuilder branch from 158dbbd to d72c8d5 Compare September 6, 2018 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants