feat: Added interrupt option to Conversation and useConversation #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plus one this is a much needed thing in the sdk |
AngeloGiacco
approved these changes
Mar 17, 2025
|
lgtm but can you give send off as well @aarthificial |
aarthificial
requested changes
Mar 18, 2025
| @@ -438,6 +438,10 @@ export class Conversation { | |||
| this.lastFeedbackEventId = this.currentEventId; | |||
| this.updateCanSendFeedback(); | |||
| }; | |||
|
|
|||
| public interrupt = () => { | |||
| return this.fadeOutAudio() | |||
There was a problem hiding this comment.
We should set the lastInterruptionTimestamp to the currentEventId to prevent future audio chunks streamed for the current agent response from canceling the fadeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for a "click to interrupt" feature