Skip to content

Default to built-in tools for ZIP archives on MacOS #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

exkrexpexfex
Copy link
Contributor

to avoid NFC-NFD conversion for libarchive
Fix #2613

to avoid NFC-NFD conversion for libarchive 
Fix #2613
elfmz added a commit that referenced this pull request Mar 29, 2025
…hing when comparing filenames for extraction (touch #2613 #2696)
@elfmz
Copy link
Owner

elfmz commented Mar 29, 2025

я тут вкомитил несколько менее радикальное решение..

@exkrexpexfex
Copy link
Contributor Author

@elfmz фикс работает, спасибо! Но собрал не с первого раза, после сегодняшнего коммита мой cmake перестал находить libarchive из homebrew. Собираю по инструкции из README.md, указываю PKG_CONFIG_PATH как написано

вернул проверку, чтобы библиотека похвалилась вот так

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 590168a3..98aebc67 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -395,18 +395,20 @@ if (NOT DEFINED MULTIARC OR MULTIARC)

     find_package(PkgConfig REQUIRED)
     pkg_search_module(LibArchive QUIET libarchive)
-    find_package(LibArchive)
-    if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
-        # workaround for MacOS brew's/macports' libarchive
-        if(IS_DIRECTORY "/usr/local/opt/libarchive/include")
-            set(LibArchive_INCLUDE_DIR "/usr/local/opt/libarchive/include")
-            set(LibArchive_LIBRARY "/usr/local/opt/libarchive/lib/libarchive.dylib")
-        elseif(EXISTS "/opt/local/lib/libarchive.dylib")
-            set(LibArchive_LIBRARY "/opt/local/lib/libarchive.dylib")
-        endif()
+    if(NOT LibArchive_FOUND)
         find_package(LibArchive)
-        if(NOT LibArchive_FOUND)
-            message(WARNING "${ColorRed}libarchive not found, multiarc will have weaker archives support. Its recommended to install libarchive-dev and reconfigure far2l.${ColorNormal}")
+        if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
+        # workaround for MacOS brew's/macports' libarchive
+            if(IS_DIRECTORY "/usr/local/opt/libarchive/include")
+                set(LibArchive_INCLUDE_DIR "/usr/local/opt/libarchive/include")
+                set(LibArchive_LIBRARY "/usr/local/opt/libarchive/lib/libarchive.dylib")
+            elseif(EXISTS "/opt/local/lib/libarchive.dylib")
+                set(LibArchive_LIBRARY "/opt/local/lib/libarchive.dylib")
+            endif()
+            find_package(LibArchive)
+            if(NOT LibArchive_FOUND)
+                message(WARNING "${ColorRed}libarchive not found, multiarc will have weaker archives support. Its recommended to install libarchive-dev and reconfigure far2l.${ColorNormal}")
+            endif()
         endif()
     endif()

@elfmz
Copy link
Owner

elfmz commented Mar 30, 2025

а где у вас находится brew? и его libarchive.dylib ?

@elfmz
Copy link
Owner

elfmz commented Mar 30, 2025

и - в текущем варианте все еще не находит?
у меня просто в вашем варианте не находит путь к libarchive.dylib из MacPorts, а использует системную, из /usr/lib/ - какую то старую, в которой половины функций нету...

@exkrexpexfex
Copy link
Contributor Author

@elfmz в текущем варианте заработало! Нашлась в /opt/homebrew

-- MULTIARC plugin enabled
-- Could NOT find LibArchive (missing: LibArchive_INCLUDE_DIR) (found version "3.7.7")
-- Detected BREW_PREFIX=/opt/homebrew
-- Found LibArchive: /opt/homebrew/opt/libarchive/lib/libarchive.dylib (found version "3.7.7")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants