fix: race condition tracking current ui #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elgato-AStory
requested changes
Jun 7, 2024
There was a problem hiding this comment.
In order to properly resolve the race condition, I think a stack or count is absolutely required. This is most noticeable if you select an already-selected action. The new PI will fire the DidAppear before the DidDisappear will fire, and since it's the same action, all of the state info about it will also be the same, and we'll end up in a scenario where the PI is open but the plugin will think it's closed.
As long as we're just clearing a variable, a simple counter should work.
|
Good suggestion; I've added a debounce counter to offset appear / disappear being out of sync for the same property inspector. |
Elgato-AStory
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a race condition, when tracking the current UI, that can occur when open/closing the property inspector in quick succession, causing the
propertyInspectorDidAppearandpropertyInspectorDidDisappearto run out of sync.